Support configuration options for GraphQLHttpClient#35
Open
jballe wants to merge 2 commits intoSitecore:mainfrom
Open
Support configuration options for GraphQLHttpClient#35jballe wants to merge 2 commits intoSitecore:mainfrom
jballe wants to merge 2 commits intoSitecore:mainfrom
Conversation
Contributor
Author
|
I have added a sample implementation using this configure feature at https://github.com/jballe/Sitecore-ASP.NET-SDK-IntegrationTest |
Member
Could you explain why this is desirable? I might be misunderstanding but doesn't this mean that a misconfiguration of the application is simply detectable much later rather than sooner? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use SitecoreGraphQlClientOptions for GraphQLHttpClient and support Configure
Description / Motivation
With this change it is possible to configure the
GraphQLClientwith Configure in DependencyInjection.e.g. in a
WebApplicationFactorycallservices.Configure<SitecoreGraphQlClientOptions>(cfg => cfg.HttpMessageHandler = _mockClientHandler);The value is already consumed through dependency injection in eg.
GraphQlSiteInfoServiceThe consequence is that any validation error are thrown upon first time the
GraphQLHttpClientis resolved instead of on initial call toAddGraphQlClientduring application setup.Testing
Terms